ci: Compile integration tests in CI#4907
Open
johnsaigle wants to merge 3 commits into
Open
Conversation
Update the live integration test to call the package-level validateTransactionResult function introduced in wormhole-foundation#4705. This preserves the same validation behavior; only the obsolete Parser receiver is removed. Drop the tagged synthetic failure and empty-result cases because equivalent tests already run in parse_test.go without build tags. The XRPL package passes both its normal tests and integration-tagged compile check.
SuiTransaction.Digest was renamed to TxDigest in commit 518d13e (PR wormhole-foundation#4850). The live integration test was not updated. Fixed the test by: - Using tx.TxDigest. - Retaining the nil check. - Adding an equality assertion against the requested digest.
johnsaigle
marked this pull request as ready for review
July 20, 2026 10:33
johnsaigle
requested review from
SEJeff,
bemic,
djb15,
evan-gray,
kcsongor,
mdulin2,
panoel and
pleasew8t
as code owners
July 20, 2026 10:33
bemic
approved these changes
Jul 20, 2026
mdulin2
requested changes
Jul 21, 2026
mdulin2
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Makefile target that compiles the Go integration tests (gated by the
-integrationflag).These tests currently get run manually during development, and not as a part of CI. This is fine, but recent refactoring has introduced syntax errors that we would not have seen until the next time these tests were run.
This PR ensures that the integration tests continue to compile by doing a fast, cheap build step as part of the
node-testsCI target. If syntax errors occur, CI will fail.This PR also adds minimal fixes for the existing syntax errors.